Comments on: Stage, Build, Review with Git, Gerrit, Hudson and Mylyn

By: Steffen Pingel

Steffen Pingel — Fri, 02 Sep 2011 22:43:38 +0000

Yes, this works identically for Jenkins. At this point the remote APIs provided by Hudson and Jenkins that the Eclipse integration is based on are very similar so the connector offers the same level of features for both.

By: C. Daniel Chase

C. Daniel Chase — Fri, 02 Sep 2011 12:49:13 +0000

Does this work with Jenkins as well as Hudson? While for most purposes they are very similar, I expect there may be minor API differences. I will attempt this with my Jenkins install, and advise if any issues arise. Just wondering if anyone had already done so.

By: Peter Jönsson

Peter Jönsson — Thu, 21 Jul 2011 07:30:01 +0000

Thanks! I’ll be watching the bug and I can verify it if/when there is a solution.

By: Steffen Pingel

Steffen Pingel — Wed, 20 Jul 2011 18:47:20 +0000

The Git repository is indeed searched based on the URL of the Gerrit repository. I have taken a quick look at the code and the host information of the actual Git repository is available through the Gerrit configuration. I have filed a bug to improve the look-up logic:

352647: fetch fails if URL of Git server does not match Gerrit server
https://bugs.eclipse.org/bugs/show_bug.cgi?id=352647

By: Peter Jönsson

Peter Jönsson — Wed, 20 Jul 2011 18:00:27 +0000

Thanks for the reply The thing is that I am forced to host our Gerrit server in the following way:

[gerrit]
canonicalWebUrl = https://cpp-gerrit..se/
[sshd]
listenAddress = gerrit..se:29418

So there will never be a match for a remote with cpp-gerrit , they all use gerrit..se .

By: Steffen Pingel

Steffen Pingel — Wed, 20 Jul 2011 17:55:14 +0000

For the compare editor files are directly downloaded from the Gerrit server through HTTP using the same mechanism that is used to retrieve changes. If I understand correctly, you are using the fetch button which searches for a matching Git repository in the workspace. If a matching repository is found a dialog, provided by EGit, is shown for fetching a particular branch. If this is not working as expected please file a bug against the Mylyn Reviews project and include any relevant errors from the error log: http://eclipse.org/mylyn/support/. Thanks!

By: Peter Jönsson

Peter Jönsson — Wed, 20 Jul 2011 14:04:36 +0000

Hi!

We run the Gerrit website on a different URL (apache reverse proxy) than the SSH server (we need to do that for internal company reasons) and therefore fetch-click fails. I assume mylyn/eclipse tries to use the same hostname for downloading the patch will be same as for the review data downloaded? Or does it search all your local git-repos for a matching remote?

In the Gerrit web interface the git/repo fetch commands we have are correct, so I guess this information retrieved and parsed?

By: Steffen Pingel

Steffen Pingel — Fri, 08 Jul 2011 21:05:26 +0000

@Stefan, very good point. Using the clone wizard is certainly much easier than manually configuring the ref spec. My blog post followed the setup tutorial but I agree that HEAD:refs/for/master is a good recommendation.

@Olivier, the described connectors interface directly with the Hudson’s REST and Gerrit’s JSon API and do not use OSLC at the moment. It’s certainly a consideration for the future once that becomes available on the server side.

By: Olivier Berger

Olivier Berger — Wed, 06 Jul 2011 04:46:14 +0000

How much OSLC could be used in all of this (or is already) ?

By: Stefan Lay

Stefan Lay — Tue, 05 Jul 2011 16:24:44 +0000

Great article!

I have one remark:

I would not recommend to use the push ref spec configuration refs/heads/*:refs/for/*.
Normally you use multiple local feature branches but you push to only one or two branches on gerrit. With the push ref spec above you have to name the local branch the same as the remote branches on gerrit.

I use HEAD:refs/for/master. This refspec is generated automatically if you go to the last page of the CloneWizard and select the checkbox “Configure Pushing Changes to Gerrit Code Review” (http://wiki.eclipse.org/EGit/User_Guide#Gerrit_Configuration).